SourceGenerators: Work Graph Keys + Create facade + Verify - #315
Merged
Conversation
Emit {Holder}WorkStepKeys and {Holder}WorkGraph.Create from
[WorkGraph]/[WorkStep] catalogs, sharing WorkGraphBuilder execution
and reporting DP087–DP092 at compile time.
Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
Lock Keys/Create emission for diamond and multi-root catalogs plus the DP087–DP092 diagnostic matrix. Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
Record the SourceGenerators dual-path emission and DP087–DP092 reporting under Unreleased. Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
Emit Create for empty [WorkGraph] holders so Build rejects at runtime, share successor-map construction, and drop dead DependsOn parsing. Co-authored-by: 落笔wys <Skymly@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement attribute-driven Fork–Join Work Graph generation:
{Holder}WorkStepKeysand{Holder}WorkGraph.Create(resolver|dictionary)fillWorkGraphBuilderso the generated path shares runtime wave/fail-fast semantics. Compile-time diagnostics cover the MVP matrix DP087–DP092.Claim note:
agent-workinglabel / assignee could not be set (GitHub integration returned 403 on issue mutations). This open PR is the concurrency claim for ready-for-agent issue #311.What ships
WorkGraphGenerator(IIncrementalGenerator+ForAttributeWithMetadataName) for[WorkGraph]/[WorkGraph<TContext>]+[WorkStep]Createfacade emission (empty catalogs still emitCreatesoBuild()rejects at runtime)Design Doc / ROADMAP F3 / AGENTS pattern summary remain on #312.
Related Issue
Closes #311
Solution module
DesignPatterns.SourceGenerators/)Also touches: Verify tests under
tests/DesignPatterns.SourceGenerators.Tests/,CHANGELOG.md[Unreleased].Type of change
Test plan
dotnet test tests/DesignPatterns.SourceGenerators.Tests(Release) — 213 passed, includingWorkGraphGeneratorTests./build.ps1 --target Ci --configuration Release(targeted suite above covers SourceGenerators seam)Breaking changes
Checklist
[Unreleased]Documentation checklist